-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nativefilestream and several new methods to File
and FileStream
#98
Conversation
- Add GetFullPath. - Improve null and empty checks on several methods.
- Add new methods to File and FileStream API. - Improve/fix Intellisense comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice heavy lifting, couple of quick comments
Looks good to me. A few comments but nothing major. Thanks :) |
I have added a couple of comments regarding the native methods (as yet unimplemented). I feel that it might be advantagous to change the types of at least The type being unsigned should also improve RAM allocation. |
- Add unit tests. - Fix unit tests.
- All unit test now derive from it. - Add code to setup to wait/mount removable drives.
- RemovableDeviceEventArgs now takes a DriveInfo parameter. - Update DriveInfo to use volume index instead of handler. - Update event manager accordingly. - Fix construction of StorageEvent. - Add array of drives to properly handle insert/remove events and update files system manager. - Code optiization on a couple of methods in File system manager. - Fix namespace to align with rest of the class lib.
…eSystem into add-nativefilestream
- Add helper methods and update code accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (26)
System.IO.FileSystem.UnitTests/DirectoryUnitTests.cs
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/FileSystemUnitTestsBase.cs
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/FileUnitTests.cs
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/PathInternalUnitTests.cs
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/PathUnitTests.cs
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/System.IO.FileSystem.UnitTests.nfproj
is excluded by none and included by noneSystem.IO.FileSystem.UnitTests/packages.config
is excluded by none and included by noneSystem.IO.FileSystem/Directory.cs
is excluded by none and included by noneSystem.IO.FileSystem/DirectoryInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/DriveInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/File.cs
is excluded by none and included by noneSystem.IO.FileSystem/FileAttributes.cs
is excluded by none and included by noneSystem.IO.FileSystem/FileInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/FileStream.cs
is excluded by none and included by noneSystem.IO.FileSystem/FileSystemInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/FileSystemManager.cs
is excluded by none and included by noneSystem.IO.FileSystem/NativeFileInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/NativeFileStream.cs
is excluded by none and included by noneSystem.IO.FileSystem/NativeFindFile.cs
is excluded by none and included by noneSystem.IO.FileSystem/NativeIO.cs
is excluded by none and included by noneSystem.IO.FileSystem/Path.cs
is excluded by none and included by noneSystem.IO.FileSystem/PathInternal.cs
is excluded by none and included by noneSystem.IO.FileSystem/Properties/AssemblyInfo.cs
is excluded by none and included by noneSystem.IO.FileSystem/System.IO.FileSystem.nfproj
is excluded by none and included by noneSystem.IO.FileSystem/nanoFramework/RemovableDriveEventArgs.cs
is excluded by none and included by noneSystem.IO.FileSystem/nanoFramework/StorageEventManager.cs
is excluded by none and included by none
Files selected for processing (1)
- System.IO.FileSystem.UnitTests/packages.lock.json (1 hunks)
Files skipped from review due to trivial changes (1)
- System.IO.FileSystem.UnitTests/packages.lock.json
- Adjust setup methods on all test classes.
…eSystem into add-nativefilestream
Quality Gate passedIssues Measures |
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
@gligorov
Summary by CodeRabbit