Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements #84

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Miscellaneous improvements #84

merged 1 commit into from
Nov 12, 2021

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 12, 2021

Description

  • Add Cbrt.
  • Rework existing methods to group them, order, fix comments for Intellisense documentation.
  • Remove duplicated Clamp() methods.
  • Bump AssemblyNativeVersion to 100.0.5.4.

Motivation and Context

  • Improves alignment with .NET API.
  • No need to provide all those overloads to Clamp(). Just keep the major ones, like with most of the other methods that offer overloads depending on parameters type.

How Has This Been Tested?

  • Unit Tests added.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add Cbrt.
- Rework existing methods to group them, order, fix comments for Intellisense documentation.
- Bump AssemblyNativeVersion to 100.0.5.4.
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@josesimoes josesimoes merged commit a9fb5cd into develop Nov 12, 2021
@josesimoes josesimoes deleted the improvements- branch November 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants