-
-
Notifications
You must be signed in to change notification settings - Fork 17
Update SslProtocols to include 1.3
#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe primary change in this update involves incrementing the version number from "1.10" to "1.11" in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
nanoFramework.System.Net/Properties/AssemblyInfo.csis excluded by none and included by nonenanoFramework.System.Net/Security/NetworkSecurity.csis excluded by none and included by nonenanoFramework.System.Net/System.Net.nfprojis excluded by none and included by none
Files selected for processing (1)
- version.json (1 hunks)
Files skipped from review due to trivial changes (1)
- version.json
- Add Tls13. - Marked Tls and Tls11 as obsolete and update the doc comments to clarify that those are unsecured and shouldn't be used. - General improvements in Intellisense comments for SslProtocols. - Changed SslProtocols enum values to match .NET. - Remove exclusion from SslProtocol enum from stubs (more convenient). - Bump native assembly version to force fw with Mbed TLS >=3.5. - Bump version to 1.11.
16cb5ad to
6952b43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
nanoFramework.System.Net/Properties/AssemblyInfo.csis excluded by none and included by nonenanoFramework.System.Net/Security/NetworkSecurity.csis excluded by none and included by nonenanoFramework.System.Net/System.Net.nfprojis excluded by none and included by none
Files selected for processing (1)
- version.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- version.json
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
Summary by CodeRabbit