Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SocketType property to Socket #67

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Add SocketType property to Socket #67

merged 1 commit into from
Mar 22, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add SocketType property to Socket. Filled in in constructor.

Motivation and Context

  • TI SimpleLink get socket option doesn't implement this.
  • This is required in NetworkStream constructor for secure stream. It's fundamental in order to have support for secure sockets.
  • The implementation is not "expensive" on any perspective and it brings minor savings in native code size.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Mar 22, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Add SocketType property to Socket
bb559d1 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the add-socketype-property branch from 0547a4c to bb559d1 Compare March 22, 2019 18:49
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Mar 22, 2019
@josesimoes
Updates in System.Net assembly
854c16e 
- Updates Socket class with new field.
- Remove options for socket type as this is now provided directly in the class library.
- Udpate declaration.
- Following nanoframework/System.Net#67.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Mar 22, 2019
Merged
10 tasks
@josesimoes josesimoes merged commit 369c333 into nanoframework:develop Mar 22, 2019
@josesimoes josesimoes deleted the add-socketype-property branch March 22, 2019 18:56
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Mar 23, 2019
@josesimoes
Updates in System.Net assembly
0724fc2 
- Updates Socket class with new field.
- Remove options for socket type as this is now provided directly in the class library.
- Udpate declaration.
- Following nanoframework/System.Net#67.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Mar 26, 2019
Merged
10 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-Change Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot