Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Updating xml comments for documentation of IGpioController and IGpioPin interfaces. #31

Merged
merged 4 commits into from
Sep 19, 2018

Conversation

RoySalisbury
Copy link
Contributor

Description

Updating xml comments for documentation of new interfaces.

Motivation and Context

the documentation comments for the new IGpioController and IGpioPin interfaces were not complete.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: RoySalisbury roys@express-is.net

@nfbot
Copy link
Member

nfbot commented Sep 19, 2018

Hi @RoySalisbury,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@RoySalisbury
Copy link
Contributor Author

Not sure why the first 3 commits are showing up. The first 2 were the original PR the other day. The 3rd was the update from the base repo to my fork. Guess I might have missed a step someplace.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the quick fix. 🥇

@josesimoes josesimoes merged commit 49ff1f9 into nanoframework:develop Sep 19, 2018
@josesimoes josesimoes changed the title Updating xml comments for documentation of new interfaces. Updating xml comments for documentation of IGpioController and IGpioPin interfaces. Sep 19, 2018
@josesimoes
Copy link
Member

Not sure why the first 3 commits are showing up. The first 2 were the original PR the other day. The 3rd was the update from the base repo to my fork. Guess I might have missed a step someplace.

Probably it's missing a rebase from upstream/develop...

Also notice that you submitting PRs from your fork branch. The recommended workflow is to open a branch from your develop and use that for the active work on an issue, or feature set.
This way you: 1) always have a safe point in develop to return to; 2) can keep that work isolated and can have multiple "ongoing" working branches without interfering each other.

Check the contributing guide or a Git tutorial for details. 😉

@RoySalisbury
Copy link
Contributor Author

Ok.. I'll branch my local fork before I do any other updates. I figured since I was the only person using it, it was not that big of a deal for me. The less I had to keep merging the better. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill in the missing comments on IGpioController and IGpioPin
3 participants