Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storage.Devices to support ESP32 mount operations #32

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Added a Storage.Devices class to allow the mounting of SDCard devices from managed code
For MMC and SPI attached devices. Needed to supply SPI information and MMC data bit 4 or 1

Added a StorageFile GetFileFromPath(String path) method to allow the easy defining of an existing file to be opened.

Added a way to enumerate Internal flash drives for ESP32 or other devices

Motivation and Context

How Has This Been Tested?

Tested each method is working for ESP32 internal drive and SDcard attached via MMC or SPI
Internal drive uses SPIFFS so there are no folders, the folder functions return "not supported"

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

Also added StorageFile GetFileFromPath
Added support for internal devices for ESP32
plus Fixes
@nfbot
Copy link
Member

nfbot commented Apr 17, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2019

CLA assistant check
All committers have signed the CLA.

- Update comments for intellisense and docs.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added the Type: enhancement New feature or request label Apr 17, 2019
@josesimoes
Copy link
Member

@AdrianSoundy mind the CLA... 😉

@josesimoes josesimoes changed the title Added changes for Esp32 Add Storage.Devices to support ESP32 mount operations Apr 18, 2019
@josesimoes josesimoes merged commit 9e23526 into nanoframework:develop Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants