-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add support to process assemblies with generics <T> #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Need to have all the others properly filled in order to get parameters types.
- Add crawler to find generic parameter type. - Generic param PE record now includes parameter type.
- Add extension to encode typeRef. - Add helper class to encode/decode type tokens. - Rework dumper to make use of these.
- Update code accordingly. - Update helper class to support.
- Now using NanoTypeOrMethodDefToken.
- Add comments with names from the docs. - Remove unused padding.
- To sync enum across CLR, MDP and VS extension.
- To sync with other components.
- Include extra information to help debug and validate output. - Improve field output.
- Locals output now includes class name and type tokens (nano and CLR). - Tokens are now output with upper case hexa.
- Now only generates MetodhDef and Ref.
- Fix handling of MethodSpec.
3e4dcc4
to
e7e0e89
Compare
- Rename job for clarity sake. - Add processing of tag to use preview version of nanoCLR. - Add task to download preview version of nanoCLR on demand. - Add task to set env variable with nanoCLR for unit tests. - Fix filter for deployables.
e7e0e89
to
74ffd69
Compare
124d6ff
to
78fd60e
Compare
- Add back condition to test with preview nanoCLR.
78fd60e
to
64acfa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
[tested against nanoclr buildId 55254]
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
Chores
New Features