Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check of ESP32-S3 version #237

Merged
merged 1 commit into from
Jul 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nanoFirmwareFlasher.Library/Esp32Operations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,14 @@ public static async System.Threading.Tasks.Task<ExitCodes> UpdateFirmwareAsync(
{
// version schema for ESP32-S3
//Previously Used Schemes | Previous Identification | vM.X
// V000 | n/a | v0.0
// V001 | 0 (bug in logs) | v0.1
// V002 | n/a | v0.2

string revisionSuffix;

// so far we are only offering a single ESP32_S3 build
if (esp32Device.ChipName.Contains("revision 0.1") || esp32Device.ChipName.Contains("revision 0.2"))
if (esp32Device.ChipName.Contains("revision 0.0") || esp32Device.ChipName.Contains("revision 0.1") || esp32Device.ChipName.Contains("revision 0.2"))
{
revisionSuffix = "";
}
Expand Down