Update nanoFramework.System.IO.FileSystem assembly reference for changed SDCard #361
Conversation
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (4)
🔇 Additional comments (4)Tests/ToughTestApp/packages.lock.json (1)
The update of nanoFramework.System.IO.FileSystem to version 1.1.66 aligns with the PR objectives for SDCard functionality updates. Let's verify version consistency across all package files: ✅ Verification successfulVersion consistency verified across all package files All package files consistently use nanoFramework.System.IO.FileSystem version 1.1.66 with matching content hashes, confirming proper synchronization across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify consistent version of nanoFramework.System.IO.FileSystem across all package files
# Expected: All files should show version 1.1.66
fd -e json -x grep -l "nanoFramework.System.IO.FileSystem" {} | xargs grep -A 2 '"requested": "\[1.1.66, 1.1.66\]"'
Length of output: 2602 Tests/M5CoreTestApp/packages.lock.json (1)
The nanoFramework.System.IO.FileSystem version 1.1.66 update is consistent with other test applications. Tests/FireTestApp/packages.lock.json (1)
The nanoFramework.System.IO.FileSystem version 1.1.66 update matches across all test applications, maintaining consistency in the ecosystem. Let's verify the changelog for this version update: Tests/M5Core2TestApp/packages.lock.json (1)
The update of nanoFramework.System.IO.FileSystem from 1.1.54 to 1.1.66 matches the intended changes for SDCard functionality. Let's verify version consistency across all projects: ✅ Verification successfulVersion consistency verified across all projects All projects that depend on nanoFramework.System.IO.FileSystem are consistently using version 1.1.66. The version update has been properly applied across:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify nanoFramework.System.IO.FileSystem version consistency
# Expected: All projects should use version 1.1.66
# Find all packages.lock.json files and check the version
fd packages.lock.json --exec grep -A 2 '"nanoFramework.System.IO.FileSystem": {'
Length of output: 986 Script: #!/bin/bash
# Let's get more context by showing the full path of each packages.lock.json file
# along with the version information
fd packages.lock.json -x sh -c 'echo "=== {} ===" && grep -A 3 "nanoFramework.System.IO.FileSystem" "{}"'
Length of output: 2062 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
~~@AdrianSoundy , you probably need to update the e.g. here: (but other spec files also need a similar update)~~ it seems you have already done it since I checked. sill, there are other projects in the solution that must be referencing FS |
|
@networkfusion |
Oh, I hate when that happens. |
|
No need to complete this PR as another PR has resolved problem |
3 participants
Description
Update M5stack project to support latest nanoFramework.System.IO.FileSystem with SDCard updates.
Motivation and Context
Build broken
How Has This Been Tested?
Builds locally
Types of changes
Checklist:
Summary by CodeRabbit
New Features
nanoFramework.System.IO.FileSystemdependency version to1.1.66across multiple projects.Bug Fixes
System.IO.FileSystemdependency.