Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EditorConfig and spelling_exclusion.dic #138

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

frobijn
Copy link
Contributor

@frobijn frobijn commented Oct 21, 2024

Description

This commit contains the final versions of .editorConfig and spelling_exclusion.dic as discussed in #134.

Motivation and Context

See discussion in #tools in Discord. The .editorconfig file is the only supported way (by Microsoft) to add repository-specific settings that control the behavior of the Visual Studio editor - as an alternative to changing the global Visual Studio settings. It is the only way to configure the spell checker.

How Has This Been Tested?

  • Spell checked all C# source code in this repository.
  • Added a space to every C# source file from every project and saved it with auto-formatting on. According to git, the resulting file was unchanged.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Copy link

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title EditorConfig and spelling_exclusion.dic added Adding EditorConfig and spelling_exclusion.dic Oct 22, 2024
@josesimoes josesimoes enabled auto-merge (squash) October 22, 2024 09:06
@josesimoes josesimoes merged commit 15c87ec into nanoframework:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants