Skip to content

Conversation

josesimoes
Copy link
Member

Description

  • Setting the device local var was failing because of a wrong if clause.

Motivation and Context

  • If RealHardwarePort is not set (or empty) in the run.settings file, a device discovery is performed. Following this, provinding that devices are present, the 1st one from the list should be target and set as the device. The if clause was wrong failing to set that device local var which caused a null exception right out of the gate when starting the execute tests section.

How Has This Been Tested?

  • Running the PoC test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@josesimoes josesimoes merged commit c713b14 into nanoframework:main Mar 21, 2024
@josesimoes josesimoes deleted the fix-device-discovery branch March 21, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants