-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up messages and make all messages consistent #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to these were using Debug.WriteLine which does not work in a release build. Using Console.WriteLine allows the TestLauncher to be built in Release mode when uploaded to Nuget. Fix #738
Message should report that the exception is that the two values are equal. Fix #715
Noticed during testing - this is second attempt. After looking at more examples of "not" logic decided to use message text like "should not be" as being easier to understand and is consistent with use of "not" in the other cases. Fix #708
josesimoes
changed the title
Clean up more of not equal messages, and make all messages consistent in the use of the word "not"
Clean up messages and make all messages consistent
May 29, 2021
josesimoes
approved these changes
May 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Running the CoreLibrary tests on win32
Screenshots
Types of changes
Checklist: