Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up messages and make all messages consistent #63

Merged
merged 11 commits into from
May 29, 2021

Conversation

edleno2
Copy link
Contributor

@edleno2 edleno2 commented May 29, 2021

Description

  • Correct more cases of not-equal that had copy/paste message from the equal case.
  • Went back and reworked ALL not-equal cases to use "should not" such that all messages are stated with "not some case".

Motivation and Context

How Has This Been Tested?

Running the CoreLibrary tests on win32

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

edleno2 and others added 11 commits May 13, 2021 20:30
Prior to these were using Debug.WriteLine which does not work in a release build.  Using Console.WriteLine allows the TestLauncher to be built in Release mode when uploaded to Nuget.

Fix #738
Message should report that the exception is that the two values are equal.

Fix #715
Noticed during testing - this is second attempt.  After looking at more examples of "not" logic decided to use message text like "should not be" as being easier to understand and is consistent with use of "not" in the other cases.

Fix #708
@josesimoes josesimoes changed the title Clean up more of not equal messages, and make all messages consistent in the use of the word "not" Clean up messages and make all messages consistent May 29, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@josesimoes josesimoes merged commit b9905f4 into nanoframework:develop May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants