Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting library to remove dependency of Windows.Storage #227

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Oct 11, 2023

Description

Adjusting to remove Windows Storage by System.IO.FileSystem. Creating 2 nugets with one nanoFramework.WebServer which is independent of storage and one nanoFramework.WebServer.FileSystem which is dependant on it.

Motivation and Context

  • Adjusting to remove Windows Storage by System.IO.FileSystem
  • Will work on much more devices and Windows Storage is obsolete
  • Creating 2 nugets with one nanoFramework.WebSer which is independent of storage and one nanoFramework.WebServer.FileSystem which is dependant on it
  • Need to be tested
  • Need to adjust the README
  • Need to adjust the Samples repository

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J

README.md Outdated Show resolved Hide resolved
nanoFramework.WebServer.nuspec Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Another step towards a better quality in our libraries.
Thanks.

@josesimoes josesimoes changed the title Adjusting to remove Windows Storage Splitting library to remove dependency of Windows.Storage Oct 25, 2023
@josesimoes josesimoes merged commit d43914f into main Oct 25, 2023
5 checks passed
@josesimoes josesimoes deleted the replace-windows-storage branch October 25, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants