Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IDF to v5.2.3 #238

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Migrate IDF to v5.2.3 #238

merged 1 commit into from
Nov 8, 2024

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 8, 2024

Description

  • Update AZDO yaml accordingly.

Targets affected

  • BrainPad2
  • GHI_FEZ_CERB40_NF
  • GHI_FEZ_CERBERUS_NF
  • I2M_ELECTRON_NF
  • I2M_OXYGEN_NF
  • MBN_QUAIL
  • NESHTEC_NESHNODE_V1
  • NETDUINO3_WIFI
  • PybStick2x
  • ST_NUCLEO64_F401RE_NF
  • ST_NUCLEO64_F411RE_NF
  • ST_STM32F411_DISCOVERY
  • ST_NUCLEO144_F412ZG_NF
  • ST_NUCLEO144_F746ZG
  • ST_STM32F4_DISCOVERY
  • ST_NUCLEO144_F439ZI
  • WEACT_F411CE
  • TI_CC1352P1_LAUNCHXL_868
  • TI_CC1352P1_LAUNCHXL_915
  • LilygoTWatch2020
  • LilygoTWatch2021
  • BUILD ALL

Motivation and Context

How Has This Been Tested?

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Summary by CodeRabbit

  • Chores
    • Updated version reference for the esp32_idf repository to v5.2.3.
    • Incremented the REVISION variable across multiple build jobs to reflect the latest updates.
    • Introduced new configuration variables for specific build jobs to enhance clarity and maintainability.
    • Improved error handling by restructuring the build failure reporting process.

Copy link

coderabbitai bot commented Nov 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in the azure-pipelines.yml file involve updates to version references and build job configurations. The reference for the esp32_idf repository has been updated from version 5.2.2 to 5.2.3. Additionally, the REVISION variable for multiple build jobs has been incremented from 1_12_0 to 1_12_1. New variables such as IDF_PATH, IDF_Target, and TargetName have been introduced for specific jobs. The Report_Build_Failure job has also been modified to depend on a comprehensive list of build jobs to ensure proper failure notifications.

Changes

File Change Summary
azure-pipelines.yml - Updated ref for esp32_idf from v5.2.2 to v5.2.3.
- Incremented REVISION variable from 1_12_0 to 1_12_1 for multiple build jobs.
- Added IDF_PATH, IDF_Target, and TargetName variables to Build_LilygoTWatch2020 and Build_LilygoTWatch2021.
- Modified Report_Build_Failure job to depend on a comprehensive list of build jobs.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@josesimoes josesimoes merged commit 4569656 into main Nov 8, 2024
1 of 2 checks passed
@josesimoes josesimoes deleted the idf-5.2.3 branch November 8, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants