Bump IDF version and build counter #249

josesimoes · 2025-09-17T09:07:08Z

Description

Update IDF version.
Bump version counter to 1.14.0.

Targets affected

Motivation and Context

Following Update to IDF 5.4.2 and add basic ESP32_P4 support nf-interpreter#3152.

How Has This Been Tested?

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Summary by CodeRabbit

Chores
- Upgraded ESP-IDF to v5.4.2 to align builds with the latest platform improvements.
- Incremented firmware revision counters to 1.14.0 across supported boards/targets for upcoming release artifacts.
- Adjusted build pipeline configuration for ESP32/Lilygo targets (IDF tag and partition settings); no changes to build steps or runtime behavior.

coderabbitai · 2025-09-17T09:07:17Z

Walkthrough

Bumped ESP-IDF reference in azure-pipelines.yml from refs/tags/v5.2.3 to refs/tags/v5.4.2 and updated many pipeline REVISION identifiers from variants of 1_12_4 to 1_14_0. Also adjusted some IDF_TAG and partitionsDirectory parameters for ESP32/Lilygo targets. No build steps or logic changes.

Changes

Cohort / File(s)	Change summary
Pipeline resource ref bump `azure-pipelines.yml`	Updated `resources.repositories.esp32_idf.ref` from `refs/tags/v5.2.3` → `refs/tags/v5.4_2`.
Revision counters (many jobs) `azure-pipelines.yml`	Replaced numerous job `REVISION` identifiers from variants of `..._1_12_4` to `..._1_14_0` (examples: `MBN_QUAIL_`, `NESHTEC_NESHNODE_V1_`, `BrainPad2_`, `GHI_FEZ_`, `I2M_`, `WEACT_F411CE_`, `ST_NUCLEO_`, `TI_CC1352P1_`, `PybStick2x_`, `LilygoTWatch2020/2021_`, `NETDUINO3_WIFI_`). No other job steps or logic altered.
ESP32 / Lilygo IDF and partitions params `azure-pipelines.yml`	Added/updated `IDF_TAG` to `v5.4.2` and added/adjusted `partitionsDirectory` parameters for Lilygo and some ESP32 targets within the pipeline job definitions.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Bump IDF version and build counter" accurately and directly reflects the main changes in the changeset. The primary modifications are updating the ESP-IDF repository reference from v5.2.3 to v5.4.2 and incrementing the REVISION counters from 1_12_4 to 1_14_0 across numerous jobs, which the title captures with clear, specific terminology. The title is concise, avoids vague language, and provides sufficient information for a reviewer scanning the history to understand the core purpose of the PR without requiring excessive detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update-idf-version

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4e6e6f and d8a0dac.

📒 Files selected for processing (1)

azure-pipelines.yml (25 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

azure-pipelines.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Community-Targets (Check_Code_Style)
GitHub Check: Community-Targets (Build_LilygoTWatch2021)
GitHub Check: Community-Targets (Build_LilygoTWatch2020)
GitHub Check: Community-Targets (Check_Build_Options)
GitHub Check: Community-Targets (Get_Commit_Message)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

azure-pipelines.yml (1)
1262-1262: IDF_PATH likely mismatches checkout path and is hardcoded

Repo alias is esp32_idf and checkout uses “checkout: esp32_idf”. Default path becomes $(Build.SourcesDirectory)\esp32_idf, but IDF_PATH points to …\esp-idf. This can break builds when the template relies on IDF_PATH.

Avoid hardcoding D:/a/1/s; use $(Build.SourcesDirectory) instead.

Apply this diff (option A: fix variable only):
-    IDF_PATH: 'D:/a/1/s/esp-idf'
+    IDF_PATH: '$(Build.SourcesDirectory)\esp32_idf'
Do this in both LilygoTWatch2020 and LilygoTWatch2021 jobs.

Alternative (option B: keep IDF_PATH as esp-idf, move checkout):
   - checkout: esp32_idf
+    path: esp-idf
Then set:
-    IDF_PATH: 'D:/a/1/s/esp-idf'
+    IDF_PATH: '$(Build.SourcesDirectory)\esp-idf'
Also applies to: 1330-1330

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a12e64c and 7826698.

📒 Files selected for processing (1)

azure-pipelines.yml (23 hunks)

🔇 Additional comments (2)

azure-pipelines.yml (2)

47-47: ESP-IDF bump to v5.4.2 — verify toolchain/template compatibility

Please confirm templates and toolchain versions used by:

download-install-esp32-build-components.yml@templatesBuild

build-espressif-esp32-targets.yml@templatesBuild
match ESP-IDF v5.4.2 requirements (Python/CMake/Ninja/xtensa/ESP-IDF tools metadata). Update the templates if needed.

221-221: Revision counters uniformly bumped to 1_14_0 — looks good

Counters are consistent across all targets.

Also applies to: 276-276, 331-331, 386-386, 441-441, 495-495, 550-550, 605-605, 660-660, 715-715, 770-770, 825-825, 880-880, 935-935, 988-988, 1043-1043, 1100-1100, 1155-1155, 1208-1208, 1269-1269, 1337-1337, 1399-1399

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7826698 and b1a4389.

📒 Files selected for processing (1)

azure-pipelines.yml (24 hunks)

🧰 Additional context used

🪛 YAMLlint (1.37.1)

azure-pipelines.yml

[warning] 1493-1493: too many blank lines (1 > 0)

(empty-lines)

🔇 Additional comments (2)

azure-pipelines.yml (2)

47-47: Verify IDF v5.4.2 compatibility across targets.

The IDF reference has been bumped from v5.2.3 to v5.4.2. While this is within the same major version, it's a notable minor version jump. Confirm that this upgrade is compatible with all downstream build templates and the nf-interpreter repository, particularly for the ESP32 targets (LilygoTWatch2020, LilygoTWatch2021).

221-221: LGTM: Revision counter updates are consistent across all jobs.

All REVISION variables have been systematically updated from 1_12_4 to 1_14_0 across the 22 build jobs, aligning with the PR objective to bump the version counter to 1.14.0.

Also applies to: 276-276, 331-331, 386-386, 441-441, 495-495, 550-550, 605-605, 660-660, 715-715, 770-770, 825-825, 880-880, 935-935, 988-988, 1043-1043, 1100-1100, 1155-1155, 1208-1208, 1269-1269, 1337-1337, 1399-1399

azure-pipelines.yml

nfbot added Area: Config-and-Build Type: dependencies labels Sep 17, 2025

coderabbitai bot reviewed Sep 17, 2025

View reviewed changes

coderabbitai bot reviewed Oct 21, 2025

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

josesimoes added 4 commits October 21, 2025 17:35

Bump IDF version and build counter

0984a7a

dummy change

37dea67

Revert dummy chance

6f11f1a

dummy change

e4e6e6f

josesimoes force-pushed the update-idf-version branch from b1a4389 to e4e6e6f Compare October 21, 2025 16:35

More fixes in AZDO pipeline

d8a0dac

josesimoes merged commit 38bea02 into main Oct 21, 2025
8 checks passed

josesimoes deleted the update-idf-version branch October 21, 2025 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Bump IDF version and build counter #249

Bump IDF version and build counter #249

Uh oh!

josesimoes commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Bump IDF version and build counter #249

Bump IDF version and build counter #249

Uh oh!

Conversation

josesimoes commented Sep 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Targets affected

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

josesimoes commented Sep 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 17, 2025 •

edited

Loading