Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework I2C native code #1014

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Rework I2C native code #1014

merged 1 commit into from
Nov 23, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Update I2C native classes following new implementation of class library.
  • Move some code from device class to controller class.
  • Add defines and declarations for I2C pin config.
  • Add I2C config on all SMT32 targets.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Breaking-change labels Nov 23, 2018
@nfbot
Copy link
Member

nfbot commented Nov 23, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

Waiting for review of nanoframework/Windows.Devices.I2c#36.

@josesimoes
Rework I2C native code
e9f0f18 
- Update I2C native classes following new implementation of class library.
- Move some code from device class to controller class.
- Add defines and declarations for I2C pin config.
- Add I2C config on all SMT32 targets.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 3fb744a into nanoframework:develop Nov 23, 2018
@josesimoes josesimoes deleted the update-i2c-native branch November 23, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-change Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust GPIO pin config for I2C
2 participants
@josesimoes @nfbot