Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native implementation of Devices.Can #1087

Merged
merged 27 commits into from
Dec 6, 2018
Merged

Add native implementation of Devices.Can #1087

merged 27 commits into from
Dec 6, 2018

Conversation

sjmneves
Copy link
Contributor

@sjmneves sjmneves commented Dec 6, 2018 •
edited by josesimoes
Loading

⚠️ ONLY FOR STM32, ESP32 NOT IMPLEMENTED ⚠️

Description

  • Add native implementation of Devices.Can.

Motivation and Context

How Has This Been Tested?

  • CAN sample from samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sjmneves sergio.neves@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Dec 6, 2018

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Dec 6, 2018
@josesimoes josesimoes force-pushed the work-417-add-support-can branch from b6208ff to 6940d25 Compare December 6, 2018 13:24
josesimoes
josesimoes requested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replicate the changes to the STM32F429 and F769 targets.

CMake/Modules/CHIBIOS_STM32F4xx_sources.cmake Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ST_STM32F4_DISCOVERY/nanoCLR/halconf.h Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ST_STM32F4_DISCOVERY/nanoCLR/halconf.h Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ST_STM32F4_DISCOVERY/nanoCLR/halconf_nf.h Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ST_STM32F4_DISCOVERY/nanoCLR/mcuconf.h Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ST_STM32F4_DISCOVERY/target_nf_devices_can_config.cpp Show resolved Hide resolved
@josesimoes josesimoes merged commit 844279c into nanoframework:develop Dec 6, 2018
@josesimoes josesimoes deleted the work-417-add-support-can branch December 6, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request -> Add support for CAN bus
3 participants
@sjmneves @nfbot @josesimoes