Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CAN in NETDUINO3_WIFI #1122

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Add support for CAN in NETDUINO3_WIFI #1122

merged 1 commit into from
Dec 21, 2018

Conversation

KoKoa14
Copy link

@KoKoa14 KoKoa14 commented Dec 21, 2018 •
edited by josesimoes
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Dec 21, 2018

Hi @geminids14,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

josesimoes
josesimoes approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks 👍 😃

@josesimoes josesimoes changed the title NETDUINO3_WIFI: nanoFramework.Devices.Can Implemented Add support for CAN in NETDUINO3_WIFI Dec 21, 2018
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Dec 21, 2018
@josesimoes josesimoes merged commit dddbbae into nanoframework:develop Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KoKoa14 @nfbot @CLAassistant @josesimoes @geminids14