Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1-Wire configuration files inclusion #1145

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix 1-Wire configuration files inclusion #1145

merged 1 commit into from
Jan 9, 2019

Conversation

josesimoes
Copy link
Member

Description

  • 1-Wire config files are now C++.
  • Fix include chain.
  • Reflect 1-Wire API CMake build option in target template with HAL_USE_STM32_ONEWIRE_OPTION.
  • Remove HAL_USE_STM32_ONEWIRE from halconf_nf in all targets.

Motivation and Context

  • Definitive fix for include and option of 1-Wire API and configuration files which was a bit messy.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix 1-Wire configuration files inclusion
cf60c3a 
- 1-Wire config files are now C++.
- Fix include chain.
- Reflect 1-Wire API CMake build option in target template with HAL_USE_STM32_ONEWIRE_OPTION.
- Remove HAL_USE_STM32_ONEWIRE from halconf_nf in all targets.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Jan 9, 2019
@nfbot
Copy link
Member

nfbot commented Jan 9, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 3331fe8 into nanoframework:develop Jan 9, 2019
@josesimoes josesimoes deleted the fix-stm32-onewire-includes branch January 9, 2019 17:31
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Jan 9, 2019
@josesimoes
Fix 1-Wire configs
a4af1b6 
- Following nanoframework/nf-interpreter#1145.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>

#ST_NUCLEO144_F746ZG#
#ST_STM32F4_DISCOVERY#
@josesimoes josesimoes mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot