Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to includes order for ChibiOS-Contrib #1179

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Fix to includes order for ChibiOS-Contrib #1179

merged 1 commit into from
Jan 25, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Fix to includes order for ChibiOS-Contrib.

Motivation and Context

  • The include order DOES MATTER: need to add our overlay before the ChibiOS-Contrib otherwise it won't pickup the correct header.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix to includes handling of ChibiOS-Contrib
cec86fc 
- The include order DOES MATTER: need to add our overlay before the ChibiOS-Contrib otherwise it won't pickup the correct header.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jan 25, 2019
@nfbot
Copy link
Member

nfbot commented Jan 25, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1de0243 into nanoframework:develop Jan 25, 2019
@josesimoes josesimoes deleted the fix-chibios-contrib branch January 25, 2019 09:19
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Jan 25, 2019
@josesimoes
Fix to includes order for ChibiOS-Contrib
20ab40b 
- Following nanoframework/nf-interpreter#1179.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>

#ALL#
@josesimoes josesimoes mentioned this pull request Jan 25, 2019
Merged
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Jan 25, 2019
@josesimoes
Fix to includes order for ChibiOS-Contrib
2bdc233 
- Following nanoframework/nf-interpreter#1179.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>

#ALL#
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Jan 25, 2019
@josesimoes
Fix to includes order for ChibiOS-Contrib
d9184dc 
- Following nanoframework/nf-interpreter#1179.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>

#ALL#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot