Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target platform for VC++ projects to 10.0.17134.0 #1180

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Update target platform for VC++ projects to 10.0.17134.0 #1180

merged 1 commit into from
Jan 25, 2019

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • VC++ feature projects needed to have their target platform updated to a more modern version.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Update target platform for VC++ projects to 10.0.17134.0
05a093d 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: dependencies Pull requests that update a dependency file(s) or version labels Jan 25, 2019
@nfbot
Copy link
Member

nfbot commented Jan 25, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 99d825b into nanoframework:develop Jan 25, 2019
@josesimoes josesimoes deleted the update-vc-sdk branch January 25, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot