Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with nanoCLR restart #1201

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix issues with nanoCLR restart #1201

merged 1 commit into from
Feb 5, 2019

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Calling execution engine reboot on ProcessActivity() must not force hard reboot.
  • Releasing threads linked lists on execution engine clean-up can cause hard faults. It's safe to skip this because those linked lists are always properly initialized on execution engine start.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix issues with nanoCLR restart
4820fa6 
- Calling execution engine reboot on ProcessActivity() must not force hard reboot.
- Releasing threads linked list on execution engine clean-up can cause hard faults. It's safe to skip this becuase the linked lists are always properly initialized on execution engine start.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such labels Feb 5, 2019
@nfbot
Copy link
Member

nfbot commented Feb 5, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 511084c into nanoframework:develop Feb 5, 2019
@josesimoes josesimoes deleted the fix-clr-restart branch February 5, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot