Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on startup code and workflow #1207

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Move CLRStartup to common location.
  • Add documentation about CLR_SETTINGS fields.
  • EnterDebuggerLoopAfterExit option is not taken into account on device reboot on RTM build.

Motivation and Context

  • Move repeated code to common location to allow reuse.
  • EnterDebuggerLoopAfterExit was causing a device to wait for debugger connection indefinitely after application exit. The only way to leave this is to either connect a debugger or hard reset the device. None of those is appropriate for stand alone devices deployed in the field.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Breaking-change labels Feb 8, 2019
@nfbot
Copy link
Member

nfbot commented Feb 8, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Move CLRStartup to common location.
- Add documentation about CLR_SETTINGS fields.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the improve-startup-parameters branch from 25821a7 to b875544 Compare February 8, 2019 12:13
@josesimoes josesimoes merged commit 68524d5 into nanoframework:develop Feb 8, 2019
@josesimoes josesimoes deleted the improve-startup-parameters branch February 8, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Breaking-change Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants