Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes related with BlockStorage #1217

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fixes related with BlockStorage #1217

merged 1 commit into from
Feb 20, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Improve ContiguousBlockAssemblies to deal with non XIP assemblies.
  • Add missing call in nanoBooter.

Motivation and Context

  • All targets except STM32F769 were missing the required BS init in nanoBooter.
  • CLRStartup wasn't handling correctly the loading of assemblies from non XIP storage.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fixes related with BlockStorage
e8731a9 
- Improve ContiguousBlockAssemblies to deal with non XIP assemblies.
- Add missing call in nanoBooter.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Feb 20, 2019
@nfbot
Copy link
Member

nfbot commented Feb 20, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 125bb68 into nanoframework:develop Feb 20, 2019
@josesimoes josesimoes deleted the update-blockstorage branch February 20, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot