Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing call to close sockets on nanoHAL_Uninitialize #1263

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 15, 2019

Description

  • Add missing call to close sockets on nanoHAL_Uninitialize.
  • Add stub for SOCKETS_CloseConnections.

Motivation and Context

  • Without this any open socket would remain opened after CLR shutdown causing issues on the next execution. This is because the lwIP threads and network interface persist even after nanoHAL_Uninitialize.
  • STM32 ChibiOS still need a way to gracefully shutdown lwIP.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Mar 15, 2019
@nfbot
Copy link
Member

nfbot commented Mar 15, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Add stub for SOCKETS_CloseConnections.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit b70d5c7 into nanoframework:develop Mar 15, 2019
@josesimoes josesimoes deleted the fix-network-uninit branch March 15, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants