Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block storage definition for ESP32 #1267

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Update block storage definition for ESP32 to have blocks matching partition map.

Motivation and Context

  • The erase operation is performed using EPS32 API. With the block storage definition using the traditional block sector causes this operation to be called over and over with an incredible timing penalty. Using a definition with the full size of the partition as a block overcomes this and does not cause any other issues with the other operations (check erase and write).
  • Addresses Problems deploying to ESP32 devices Home#465.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels Mar 18, 2019
@nfbot
Copy link
Member

nfbot commented Mar 18, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 4fe4f12 into nanoframework:develop Mar 18, 2019
@josesimoes josesimoes deleted the update-esp32-blockstorage branch March 25, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants