Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state flag to signal failure in type load and/or resolution #1278

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add StateResolutionFailed flag to EE debug conditions.
  • Add missing check results to several calls.

Motivation and Context

  • Need a way to signal to the debugger that type load or resolution has failed. Currently that situation is output on console messages that can be either missed by VS output or completely hidden on targets that can't output those messages properly.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Add missing check results to several calls.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Apr 3, 2019
@nfbot
Copy link
Member

nfbot commented Apr 3, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 797f9ae into nanoframework:develop Apr 4, 2019
@josesimoes josesimoes deleted the improve-load-workflow branch April 4, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants