Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework execution engine mutex #1318

Merged
merged 1 commit into from
May 15, 2019
Merged

Rework execution engine mutex #1318

merged 1 commit into from
May 15, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add defines to easy enter/exit of critical section to read variable.
  • Rework calls to GLOBAL_LOCK/GLOBAL_UNLOCK.
  • Add missing GLOBAL_LOCK/GLOBAL_UNLOCK to ESP32 and CC3220SF events.
  • Rework bool event timer on ESP32 and CC3220SF to use timer ID to pass the flag.
  • Code clean-up.

Motivation and Context

  • The current implementation was long due to be refactored. Modern compilers and the use of RTOS provide new (and more efficient) approaches to this problematic.
  • See discussions and guidance related with these matters on .NETMF here and here.

How Has This Been Tested?

  • Tested with several applications from Samples repo on STM32F769, ESP32 and CC3220SF boards.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented May 15, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Work on execution engine mutex
cec32be 
- Add defines to easy enter/exit of critical section to read variable.
- Rework calls to GLOBAL_LOCK/GLOBAL_UNLOCK.
- Add missing GLOBAL_LOCK/GLOBAL_UNLOCK to ESP32 and CC3220SF events.
- Rework bool event timer on ESP32 and CC3220SF to use timer ID to pass the flag.

- Code clean-up.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes changed the title Work on execution engine mutex Rework execution engine mutex May 15, 2019
@josesimoes josesimoes merged commit 482f1b1 into nanoframework:develop May 15, 2019
@josesimoes josesimoes deleted the work-clr-mutex branch May 15, 2019 16:29
morali pushed a commit to morali/nf-interpreter that referenced this pull request May 17, 2019
@josesimoes
Rework execution engine mutex (nanoframework#1318)
d338d5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Area: Targets Breaking-change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot