Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement native dispose for STM32 targets #1334

Merged
merged 1 commit into from
May 24, 2019
Merged

Implement native dispose for STM32 targets #1334

merged 1 commit into from
May 24, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Implement native dispose for peripherals where it was missing (STM32 targets).

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels May 23, 2019
@nfbot
Copy link
Member

nfbot commented May 23, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Implement native dispose for STM32 targets
fde10d6 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the work-native-dispose branch from 40da3ac to fde10d6 Compare May 24, 2019 07:35
@josesimoes josesimoes merged commit 3dcbb22 into nanoframework:develop May 24, 2019
@josesimoes josesimoes deleted the work-native-dispose branch May 24, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot