Fix rename file issue

[AdrianSoundy]

Description

With Internal drive on ESP32 the GetFiles was adding adding an extra "\" in path which caused rename to fail. I think this is because a \ is seen as part of filename.

Could also be a problem with STM32

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

[nfbot]

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

[AdrianSoundy]

Sample code that was causing problem.

            StorageFolder internalDevices = Windows.Storage.KnownFolders.InternalDevices;

            var internalDrives = internalDevices.GetFolders();

            StorageFolder Sfolder = internalDrives[0];

            var iFile = Sfolder.CreateFile("test.txt", CreationCollisionOption.ReplaceExisting);

            
            FileIO.WriteText(iFile, "Hello from Esp32");

            var Files = Sfolder.GetFiles();

            foreach (var File in Files)
            {
                Console.WriteLine("Filename-> " + File.Name);
                Console.WriteLine("Path-> " + File.Path);

                if (File.Name == "test.txt")
                {
                    // This produces an exception CLR_E_FILE_NOT_FOUND 
                    File.Rename("text1.txt");

                    // This works
                    //    var ifile = StorageFile.GetFileFromPath(Sfolder.Path + "test.txt");
                    //    ifile.Rename("test1.txt");

                }
                if (File.Name == "text1.txt")
                {
                    File.Delete();
                }

            }

[josesimoes]

Nice catch @AdrianSoundy ! 👏

Let me check on the STM32 targets before we have this one merged.

[AdrianSoundy]

The problem was reported by DWeaver directly to me.

I think with FatFS it ignores any extra "\"
The problem happens when you combine a drive letter with a filename
I:\ + test1.txt = I:\\test1.txt , the code was adding the separator \ which already existed
When in a folder the separator it is needed.
C:\folder + test1.txt = C:\Folder\test1.txt

For Esp32 we convert to internal VFS path
I:\\test1.txt -> \I\\test1.txt which should have been \I\test1.txt
So filename ended up as \test1.txt

[josesimoes]

The code for STM32 is already taking care of this.

The test code above runs just fine on STM32F769I-DISCO loaded with an SD Card.