Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting of ResolutionFailed flag on boot #1353

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix setting of ResolutionFailed flag on boot #1353

merged 1 commit into from
Jun 6, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Fix setting of ResolutionFailed flag on boot.
  • Also added this to the Win32 test project.

Motivation and Context

  • The flag was wrongly being set on type resolution failed and also when there is no managed app to execute.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix setting of ResolutionFailed flag on boot
e8ab0b4 
- The flag was wrongly being set on type resolution failed and also when there is no mamaged app to execute.
- Also added this to the Win32 test project.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Interpreter Everything related with the interpreter, execution engine and such labels Jun 6, 2019
@nfbot
Copy link
Member

nfbot commented Jun 6, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 2e794f2 into nanoframework:develop Jun 6, 2019
@josesimoes josesimoes deleted the fix-resolution-failed-flag branch June 6, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot