Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return value on SerialCommunication Store() call #1369

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Fix return value on SerialCommunication Store() call #1369

merged 1 commit into from
Jun 16, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Not returning the number bytes written on Store
Now returns this

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adiansoundyadiansoundy@gmail.com

@AdrianSoundy
COM fix 2
5d5c80b 
Not returning the number bytes written on Store
Now returns this
@nfbot
Copy link
Member

nfbot commented Jun 16, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit f03b05c into nanoframework:develop Jun 16, 2019
@AdrianSoundy AdrianSoundy deleted the com-fix2 branch June 16, 2019 05:32
@josesimoes josesimoes changed the title COM fix 2 Fix return value on SerialCommunication Store() call Jun 18, 2019
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes