Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target and platform name to NFReleaseInfo #1379

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Add target and platform name to NFReleaseInfo #1379

merged 1 commit into from
Jun 20, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add fields to structure.
  • Rework all functions calling/using them.
  • Add new strings to all targets.
  • Add defines to vcx projects.
  • Remove NFReleaseInfo::Init from debugger as the weak implementation from debugger stubs is OK.

Motivation and Context

How Has This Been Tested?

  • Test app on debugger solution.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Jun 20, 2019
@nfbot
Copy link
Member

nfbot commented Jun 20, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the work-414 branch 2 times, most recently from b2ed538 to c99b6a8 Compare June 20, 2019 20:55
@josesimoes
Add target and platform name to NFReleaseInfo
f5fd9fe 
- Add fields to structure.
- Rework all functions calling/using them.
- Add new strings to all targets.
- Add defines to vcx projects.
- Remove NFReleaseInfo::Init from debugger as the weak implementation from debugger stubs is OK.
- Increase CLR region size for TI CC3220SF.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 7a6bf2e into nanoframework:develop Jun 20, 2019
@josesimoes josesimoes deleted the work-414 branch June 20, 2019 21:29
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 20, 2019
@josesimoes
Update Runtime.Native assembly and implementation
225e388 
- Following nanoframework#1379.
- Add code to fill in the new functions to retrieve Platform and TargetName from NFReleaseInfo struct.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Jun 20, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot