Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted nanoCLR.VC.db #138

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Deleted nanoCLR.VC.db #138

merged 1 commit into from
Mar 1, 2017

Conversation

cw2
Copy link
Contributor

@cw2 cw2 commented Feb 27, 2017

Obvious fix

@cw2 cw2 requested a review from josesimoes February 27, 2017 23:08
@nfbot
Copy link
Member

nfbot commented Feb 27, 2017

Hi @cw2,

I'm nanoFramework bot.
Thank you for your contribution!

It seems that the DCO signed-off or an 'obvious fix' mention are missing in the commit(s) message(s).
Please make sure that you've:

  1. Followed the Contribution Workflow.
  2. Signed off the commit(s) following the instructions about the Developer Certificate of Origin or an Obvious Fix mention.

A human will be reviewing it shortly. 😉

@cw2
Copy link
Contributor Author

cw2 commented Feb 27, 2017

Does the end-of-line characters check work properly in nfbot? It's possible that CR LF is transformed to LF only...

@ghost
Copy link

ghost commented Feb 28, 2017

Nothing related to the PR but I am "happy" that someone else than me has issues with DCO checks.
I feel less alone :)

Sorry for the useless comment.

@cw2
Copy link
Contributor Author

cw2 commented Feb 28, 2017

@MikroBusNet Someone should have been following the specification and not making the bot too smart. As far as I understand it, I could easily circumvent its DCO check by using the same text in my name and signoff line, as long as it matches the bot will not complain - despite the fact it is not real name (which was the reason for two stage process involving human verification). But I first need to check this with @josesimoes, the process has to be fixed.

@nfbot
Copy link
Member

nfbot commented Feb 28, 2017

Dear @cw2,

Please forgive me for not correctly detecting the DCO signoff. This will not happen again. I am now going to compute a sincere apology, which has the same SHA1 as the offended commit...

@nfbot
Copy link
Member

nfbot commented Mar 1, 2017

Hi @cw2,

I'm nanoFramework bot.
Thank you for your contribution!

Everything seems to be in order.
A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 6ed1a1e into nanoframework:master Mar 1, 2017
@cw2 cw2 deleted the delete-vc.db branch March 1, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants