Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ADC channel using PB8 #1383

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Remove ADC channel using PB8 #1383

merged 1 commit into from
Jun 23, 2019

Conversation

piwi1263
Copy link
Member

@piwi1263 piwi1263 commented Jun 23, 2019 •
edited by josesimoes
Loading

Description

Removed the use of PB8 for an ADC channel. Pin PB8 is used primary for I2C.

  • Removed the config for the channel
  • Updated helper class for C#

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

@piwi1263
Remove ADC channel using PB8
8b6b614 
Removed the use of PB8 for an ADC channel.

- Removed the config for the channel
- Updated helper class for C#

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Jun 23, 2019

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 self-assigned this Jun 23, 2019
@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Jun 23, 2019
josesimoes
josesimoes approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@josesimoes
Copy link
Member

Azure Pipeline failing to report build job complete.

@josesimoes josesimoes merged commit 02914ed into nanoframework:develop Jun 23, 2019
@piwi1263 piwi1263 deleted the fix-double-use-of-pb8 branch June 23, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees

@piwi1263 piwi1263

Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting pin declaration for ST_STM32F769I_DISCOVERY
3 participants
@piwi1263 @nfbot @josesimoes