Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the milli secs conversion #1384

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix the milli secs conversion #1384

merged 1 commit into from
Jun 25, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jun 25, 2019

Description

The conversion from Usecs to 100 nano secs was incorrect cause the time to show wrong

Motivation and Context

Fixes nanoframework/Home#494

How Has This Been Tested?

            while (true)
            {
                Console.WriteLine($"{DateTime.UtcNow.ToString()} - {DateTime.UtcNow.Millisecond.ToString()}");
                Console.WriteLine($"{DateTime.UtcNow.ToString()} - {DateTime.UtcNow.Millisecond.ToString()}");
                Console.WriteLine($"{DateTime.UtcNow.ToString()} - {DateTime.UtcNow.Millisecond.ToString()}");
                Console.WriteLine($"{DateTime.UtcNow.ToString()} - {DateTime.UtcNow.Millisecond.ToString()}");

                Thread.Sleep(10000);
            }
01/01/1970 00:19:55 - 386
01/01/1970 00:19:55 - 397
01/01/1970 00:19:55 - 409
01/01/1970 00:19:55 - 420
01/01/1970 00:20:05 - 426
01/01/1970 00:20:05 - 438
01/01/1970 00:20:05 - 449
01/01/1970 00:20:05 - 460
01/01/1970 00:20:15 - 466
01/01/1970 00:20:15 - 477
01/01/1970 00:20:15 - 489
01/01/1970 00:20:15 - 500

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Jun 25, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Jun 25, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@josesimoes
Copy link
Member

Azure Pipeline is not reporting the successful build completion.

@josesimoes josesimoes merged commit 570ba75 into nanoframework:develop Jun 25, 2019
@AdrianSoundy AdrianSoundy deleted the datetime branch June 26, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output from DateTime.UtcNow seems to be wrong in ESP32
3 participants