Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Add support for DAC #1390

Merged
merged 4 commits into from
Jul 1, 2019
Merged

🚧 Add support for DAC #1390

merged 4 commits into from
Jul 1, 2019

Conversation

networkfusion
Copy link
Member

Description

Motivation and Context

  • Fixes/Closes/Resolves nanoFramework/Home#NNNN

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@nfbot
Copy link
Member

nfbot commented Jun 28, 2019

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: NXP i6 Everything related specifically with NXP targets Type: enhancement Area: Common libs Everything related with common libraries Series: STM32xx Everything related specifically with STM32 targets and removed Series: NXP i6 Everything related specifically with NXP targets labels Jun 29, 2019
@josesimoes josesimoes changed the base branch from develop to develop-dac July 1, 2019 08:28
@josesimoes josesimoes changed the title Work in progress for DAC support 🚧 Add support for DAC Jul 1, 2019
@josesimoes
Copy link
Member

Build failing.

@josesimoes josesimoes merged commit f2cfcea into nanoframework:develop-dac Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@networkfusion @nfbot @josesimoes