Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hardware.Esp32 assembly #1392

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Update Hardware.Esp32 assembly #1392

merged 2 commits into from
Jul 2, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jul 2, 2019 •
edited by josesimoes
Loading

Description

Motivation and Context

How Has This Been Tested?

Using test program to display all pins used for each function

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@AdrianSoundy
Update to Hardware.Esp32
2cb8bcf 
Added support for Get / Set Pin function instead of using Gpio assembly.
Added ADC default pins
Dependency of latest nanoFramewrk.Hardware.Esp32 assembly
@AdrianSoundy
Merge branch 'develop' into Esp32-hardware
4b37539
@nfbot
Copy link
Member

nfbot commented Jul 2, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy mentioned this pull request Jul 2, 2019
Closed
10 tasks
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement labels Jul 2, 2019
josesimoes
josesimoes approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title Esp32 hardware update Update Hardware.Esp32 assembly Jul 2, 2019
@josesimoes josesimoes added Type: dependencies Pull requests that update a dependency file(s) or version and removed Type: enhancement labels Jul 2, 2019
@josesimoes josesimoes merged commit 99a7c28 into nanoframework:develop Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes