Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of GetCustomAttributes for fields #1394

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Add implementation of GetCustomAttributes for fields #1394

merged 1 commit into from
Jul 4, 2019

Conversation

MateuszKlatecki
Copy link
Member

@MateuszKlatecki MateuszKlatecki commented Jul 4, 2019

Description

Added missing implementation of getCustomAttributes for fields

How Has This Been Tested?

Tested using VS with following code

using System;

namespace FieldAttrTest
{
    public class Program
    {
        public class MyAttribute1 : Attribute
        {

        }

        public class MyAttribute2 : Attribute
        {

        }

        public class Test
        {
            [MyAttribute1]
            [MyAttribute2]
            public bool testField;
        }

        public static void Main()
        {
            var obj = new Test();
            var fieldAttr = obj.GetType().GetField("testField").GetCustomAttributes(true);

            foreach (var a in fieldAttr)
            {
                Console.WriteLine(a.ToString());
            }
        }
    }
}

Program output:

FieldAttrTest.Program+MyAttribute1
FieldAttrTest.Program+MyAttribute2

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: MateuszKlatecki mateusz.klatecki@gc5.pl

@nfbot
Copy link
Member

nfbot commented Jul 4, 2019

Hi @MateuszKlatecki,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Jul 4, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! 👏

@josesimoes josesimoes merged commit 7b2d40a into nanoframework:develop Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants