Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on Devices.Dac #1398

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Improvements on Devices.Dac #1398

merged 1 commit into from
Jul 10, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Make DAC implementation same as STM32
Add DAC pins to device mapping

How Has This Been Tested?

Using DacSample

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundyadriansoundy@gmail.com

@AdrianSoundy
Update Dac
ea5fd18 
Make DAC implementation same as STM32
Add DAC pins to device mapping
@nfbot
Copy link
Member

nfbot commented Jul 10, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes
josesimoes approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Jul 10, 2019
@josesimoes josesimoes changed the title Update Dac Improvements on Devices.Dac Jul 10, 2019
@josesimoes josesimoes merged commit 1026a58 into nanoframework:develop Jul 10, 2019
@AdrianSoundy AdrianSoundy deleted the Dac-updates branch July 11, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes