Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support larger Flash chips configurations on ESP32 #1415

Merged
merged 5 commits into from
Jul 23, 2019
Merged

Support larger Flash chips configurations on ESP32 #1415

merged 5 commits into from
Jul 23, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jul 23, 2019

Description

  • Add partition configuration files for 8Mb and 16Mb ESP32 devices
  • Dynamically update Block storage and Hal system config with actually hardware sizes.
    The Partition tables are currently just copies of 4Mb version but it will allow flashing tool to have files for the bigger Flash sizes. Partition layout can be updated later when we have a better idea on OTA programming requirements.
  • Update Azure pipeline yml and CMakeList.txt to create partition tables for 8M & 16Mb

Motivation and Context

  • Forum has user with 16Mb flash and i have device with 8Mb flash.
  • Would be good to be able to flash directly from flash tool.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

Dynamically update Block storage and Hal system config with actually hardware sizes.
@nfbot
Copy link
Member

nfbot commented Jul 23, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Missing space an changed lines
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement labels Jul 23, 2019
- Fix typos and name casing
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏

@josesimoes josesimoes merged commit 6c7afed into nanoframework:develop Jul 23, 2019
@AdrianSoundy AdrianSoundy deleted the Partition_16MB branch July 23, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants