Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration manager initialization #1424

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fix configuration manager initialization #1424

merged 1 commit into from
Jul 30, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add missing memset to cleanup struct.
  • Add check for empty struct when storing default network config block.

Motivation and Context

  • Causing hard fault on initializing a completely erased device.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix configuration manager initialization
fabfd91 
- Add missing memset to cleanup struct.
- Add check for empty struct when storing default network config block.
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jul 30, 2019
@nfbot
Copy link
Member

nfbot commented Jul 30, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 4796a5b into develop Jul 30, 2019
@josesimoes josesimoes deleted the josesimoes-patch-1 branch July 30, 2019 16:57
morali pushed a commit to morali/nf-interpreter that referenced this pull request Oct 4, 2019
@josesimoes @MateuszKlatecki
Fix configuration manager initialization (nanoframework#1424)
7ceb907 
***NO_CI***

(cherry picked from commit 4796a5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot