Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPI device getting pin config #1426

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix SPI device getting pin config #1426

merged 1 commit into from
Jul 31, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Fix to SPI pin config which was broken by previous change to ESp32 pin configuration

How Has This Been Tested?

Test with small SPI test program shown on M5Stack forum channel

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Jul 31, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit fd97dac into nanoframework:develop Jul 31, 2019
@AdrianSoundy AdrianSoundy deleted the TestSpi branch July 31, 2019 04:09
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Jul 31, 2019
morali pushed a commit to morali/nf-interpreter that referenced this pull request Oct 4, 2019
@AdrianSoundy @MateuszKlatecki
Fix SPI device getting pin config (nanoframework#1426)
82f212d 
(cherry picked from commit fd97dac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes