Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement working GetCustomAttributes #1429

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Implement working GetCustomAttributes #1429

merged 5 commits into from
Mar 9, 2020

Conversation

MateuszKlatecki
Copy link
Member

@MateuszKlatecki MateuszKlatecki commented Aug 5, 2019

Description

  • Implements native support for a real GetCustomAttributes with "simple" attributes and also ones with constructor. Currently supporting only constructors with a single parameter and only numeric and string parameters.
  • Update mscorlib declaration to follow Implement MemberInfo.GetCustomAttributesNative CoreLibrary#98.

Motivation and Context

  • Bringing to the same implementation as in the standard .net.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mateusz Klatecki mateusz.klatecki@gc5.pl
Signed-off-by: Jose Simoes jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Aug 5, 2019

Hi @MateuszKlatecki,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Aug 26, 2019
@josesimoes
Copy link
Member

I'm afraid this not possible because metadataprocessor strips out the "content" for the custom attributes. Only the attribute type is preserved and makes it to the portable executable.

For this to work it the processor would have to be changed.

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This PR hasn't been inactive for the past 60 days label Oct 26, 2019
@josesimoes
Copy link
Member

Draft PR

@stale stale bot removed the stale This PR hasn't been inactive for the past 60 days label Oct 27, 2019
@stale
Copy link

stale bot commented Jan 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale This PR hasn't been inactive for the past 60 days and removed stale This PR hasn't been inactive for the past 60 days labels Jan 19, 2020
@josesimoes josesimoes self-assigned this Feb 6, 2020
@josesimoes josesimoes marked this pull request as ready for review February 6, 2020 11:52
@josesimoes josesimoes changed the title Fix GetCustomAttributes Implement working GetCustomAttributes Feb 6, 2020
MateuszKlatecki and others added 5 commits March 9, 2020 09:29
…tribute Types

(cherry picked from commit ff0f5bea8f73633ce165e7d1259c78c75e5d5fcf)
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 60a0667 into nanoframework:develop Mar 9, 2020
@MateuszKlatecki MateuszKlatecki deleted the Fix_GetCustomAttributes branch June 22, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants