-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SoftAP interface for ESP32 #1438
Conversation
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted PR to your branch resulting from code review.
Considering that:
I'm thinking that adding support for Wi-Fi AP and respective configuration, regardless of the feature is used or not, adds to the image size. Which can become a problem as we keep adding stuff. Suggest that:
|
The Wireless AP is really useful for the initial configuration of a device in combination of a small web server to handle the config requests. I am hoping to include this as part of the sample project. I agree we need to keep the image small and don't have extra things that are not required by a platform and having a configuration option would be the best way. I thought may be later we can split the Wireless AP off into a separate managed code assembly to make that easier and reduce code for Ethernet only devices. |
Understood and that makes perfect sense. Let's have this merged and the work to split it queued up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 17d98eb.
- Mostly layout fixes to comply with coding style. *** WIP still missing the changes that will come up from the code review in the managed class lib *** Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Update classes accordingly. - Following nanoframework/System.Net#91. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Description
This PR adds the interfaces to manage the Soft Access Point on the ESP32
-- Enable, AutoStart, HiddenSSID, SmartConfig
Due to configuration block change for wireless configuration may require change in VS extension
Motivation and Context
How Has This Been Tested?
Tested with a sample application that will be added to samples
Types of changes
Checklist:
Signed-off-by: adriansoundy adriansoundy@gmail.com