Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spi SDcard fix #1444

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Spi SDcard fix #1444

merged 2 commits into from
Sep 16, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Using wrong offset for SPI device in mapping table. This was fixed for SPI device but Sdcard was missed.

How Has This Been Tested?

Using small test program to mount card

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Sep 16, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit 6a9b02d into nanoframework:develop Sep 16, 2019
@AdrianSoundy AdrianSoundy deleted the sdcard-fix branch September 16, 2019 11:29
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants