Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check to valid image verification #1451

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

antoniofagundes
Copy link
Member

Description

  • Add sanity check to flash address.

Motivation and Context

  • When the flash content at the address where the Reset vector is supposed to be has a number which will be used as address to check for the content falls off the valid flash address a hard fault occurs locking the board. This sanity check relies on the flash start address and size defined for the target to perform a sanity check on that address value.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: António Fagundesantonio.fagundes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Oct 8, 2019

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Oct 8, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoniofagundes antoniofagundes changed the title Addm sanity check to image check Add sanity check to valid image verification Oct 8, 2019
@josesimoes josesimoes merged commit 1ec952e into nanoframework:develop Oct 8, 2019
@antoniofagundes antoniofagundes deleted the patch-2 branch October 25, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants