Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GetStorageFilesNative when using SPIFFS #1462

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fix for GetStorageFilesNative when using SPIFFS #1462

merged 1 commit into from
Oct 25, 2019

Conversation

antoniofagundes
Copy link
Member

Description

  • Add missing declarations to use SPIFFS.
  • Fix var reset on second call to list directory content.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: António Fagundesantonio.fagundes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Oct 25, 2019

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Oct 25, 2019
josesimoes
josesimoes approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit 808ef88 into nanoframework:develop Oct 25, 2019
@antoniofagundes antoniofagundes deleted the patch-4 branch October 25, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateFile Throws Exception if Existing File Needs to be Overwritten on SPI Flash
3 participants
@antoniofagundes @nfbot @josesimoes