Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminators on NFReleaseInfo strings #1464

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Fix terminators on NFReleaseInfo strings #1464

merged 3 commits into from
Oct 27, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Oct 27, 2019

Description

Rubbish shown beyond end of Info , Target Name & Platform name
This was due to the strings not being properly terminated

How Has This Been Tested?

Console.WriteLine("OEMString :"+ SystemInfo.OEMString);
Console.WriteLine("TargetName :" + SystemInfo.TargetName);
Console.WriteLine("Platform :" + SystemInfo.Platform);

Now shows properly with no strange characters beyond end.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Oct 27, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy added Series: ESP32 Everything related specifically with ESP32 series targets Area: Interpreter Everything related with the interpreter, execution engine and such labels Oct 27, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@josesimoes josesimoes added Type: bug and removed Series: ESP32 Everything related specifically with ESP32 series targets labels Oct 27, 2019
@josesimoes josesimoes merged commit 2da2879 into nanoframework:develop Oct 27, 2019
@AdrianSoundy AdrianSoundy deleted the infostrings branch October 28, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants