-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for multiple block storage devices #1466
Conversation
uncomment and implement functions BlockStorageList_GetNextDevice() and BlockStorageList_GetNumDevices() to support multiple block storage devices
uncomment functions GetFirstDevice() and GetNumDevices() which are now implemented in nanoPAL_BlockStorage.c
Hi @martin-kuhn, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for taking care of this. 👏
A picky request, please: could you please follow the project coding style guide lines and move the open brackets to new lines and use spaces for tabs. 😁
Finished 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
The CLR debugger function Monitor_FlashSectorMap() is accessed in Visual Studio to detect the device capabilities and for deployment. At the moment, it does only include the first block storage device in the list, which is the internal flash of the MCU.
Motivation and Context
This change is required to support the use of an external flash memory in addition to the internal one. Flash memory regions of the external flash have to be included in the FlashSectorMap, otherwise they will not be detected any cannot be accessed from Visual Studio.
How Has This Been Tested?
This has successfully been tested on a STM32F427 based custom board with just the internal flash and also with the internal and external one.
Types of changes
Checklist: