Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for multiple block storage devices #1466

Merged
merged 7 commits into from
Oct 30, 2019
Merged

Enable support for multiple block storage devices #1466

merged 7 commits into from
Oct 30, 2019

Conversation

martin-kuhn
Copy link
Contributor

@martin-kuhn martin-kuhn commented Oct 29, 2019

Description

The CLR debugger function Monitor_FlashSectorMap() is accessed in Visual Studio to detect the device capabilities and for deployment. At the moment, it does only include the first block storage device in the list, which is the internal flash of the MCU.

Motivation and Context

This change is required to support the use of an external flash memory in addition to the internal one. Flash memory regions of the external flash have to be included in the FlashSectorMap, otherwise they will not be detected any cannot be accessed from Visual Studio.

How Has This Been Tested?

This has successfully been tested on a STM32F427 based custom board with just the internal flash and also with the internal and external one.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

uncomment and implement functions BlockStorageList_GetNextDevice() and BlockStorageList_GetNumDevices() to support multiple block storage devices
uncomment functions GetFirstDevice() and GetNumDevices() which are now implemented in nanoPAL_BlockStorage.c
@nfbot
Copy link
Member

nfbot commented Oct 29, 2019

Hi @martin-kuhn,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking care of this. 👏

A picky request, please: could you please follow the project coding style guide lines and move the open brackets to new lines and use spaces for tabs. 😁

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Oct 29, 2019
@martin-kuhn
Copy link
Contributor Author

Finished 👍
sorry I hadn't paid enough attention to this.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 8889b97 into nanoframework:develop Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants